Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent importing of flows with a spec version that is ahead of the engine #5744

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Dec 12, 2024

Weird that we've allowed this.. very much undefined behavior

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7f9b7ad) to head (1f5823a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5744   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          586       586           
  Lines        25753     25757    +4     
=========================================
+ Hits         25753     25757    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit c175ad9 into main Dec 12, 2024
5 checks passed
@rowanseymour rowanseymour deleted the prevent_importing_flows_too_new branch December 12, 2024 15:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants