Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Switch to codecov? #2265

Merged
merged 3 commits into from
Jan 25, 2019
Merged

🧹 Switch to codecov? #2265

merged 3 commits into from
Jan 25, 2019

Conversation

rowanseymour
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0a5ae31). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2265   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?     221           
  Lines             ?   26886           
  Branches          ?       0           
========================================
  Hits              ?   26886           
  Misses            ?       0           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5ae31...3ffa121. Read the comment docs.

@rowanseymour
Copy link
Member Author

Well darn looks like codecov refuses to ignore "needs cover" lines due to codecov/codecov-python#107

@rowanseymour
Copy link
Member Author

Actually no.. seems to be working.. just the comment about still says 97.77% which is a bit confusing

@rowanseymour rowanseymour merged commit a227128 into master Jan 25, 2019
@rowanseymour rowanseymour deleted the codecov branch January 25, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants