Contact queries with explicit property types part 1 #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1252 +/- ##
==========================================
+ Coverage 81.42% 81.45% +0.02%
==========================================
Files 278 278
Lines 14620 14642 +22
==========================================
+ Hits 11905 11927 +22
Misses 2148 2148
Partials 567 567 ☔ View full report in Codecov by Sentry. |
rowanseymour
commented
May 14, 2024
| @@ -5,6 +5,8 @@ import LexUnicode; | |||
| // Lexer rules | |||
| fragment HAS: [Hh][Aa][Ss]; | |||
| fragment IS: [Ii][Ss]; | |||
| fragment PROPTYPE: (UnicodeLetter)+; | |||
| fragment PROPKEY: (UnicodeLetter | UnicodeDigit | '_')+; | |||
There was a problem hiding this comment.
you could make this stuff stricter but it's actually easier to deal with errors higher up in the parser rather in the lexer
rowanseymour
commented
May 14, 2024
| @@ -21,6 +21,7 @@ const ( | |||
| ErrUnsupportedContains = "unsupported_contains" // `property` the property key | |||
| ErrUnsupportedComparison = "unsupported_comparison" // `property` the property key, `operator` one of =>, <, >=, <= | |||
| ErrUnsupportedSetCheck = "unsupported_setcheck" // `property` the property key, `operator` one of =, != | |||
| ErrUnknownPropertyType = "unknown_property_type" // `type` the property type | |||
There was a problem hiding this comment.
need to add support for this on RP side where we turn these into readable error messages
rowanseymour
commented
May 14, 2024
| if err != nil { | ||
| return NewQueryError(ErrInvalidLanguage, "'%s' is not a valid language code", c.value).withExtra("value", c.value) | ||
| // for some text attributes, do some additional validation | ||
| if c.propType == PropertyTypeAttribute { |
There was a problem hiding this comment.
little bit of reorg here so that if you have a field called language.. we don't enforce that the value is valid language code etc
ericnewcomer
approved these changes
May 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for parsing property conditions like
fields.age > 34andurns.tel != "".Note that it doesn't normalize queries to look like that - that comes in separate push otherwise there's risk of one mailroom instance creating queries the other can't parse.