13.5 #1246
13.5 #1246
Conversation
| @@ -140,16 +140,16 @@ func testActionType(t *testing.T, assetsJSON json.RawMessage, typeName string) { | |||
| // inject the action into a suitable node's actions in that flow | |||
| actionsPath := []string{"flows", fmt.Sprintf("[%d]", flowIndex), "nodes", "[0]", "actions"} | |||
| actionsJson := []byte(fmt.Sprintf("[%s]", string(tc.Action))) | |||
| assetsJSON = test.JSONReplace(assetsJSON, actionsPath, actionsJson) | |||
| testAssetsJSON := test.JSONReplace(assetsJSON, actionsPath, actionsJson) | |||
There was a problem hiding this comment.
not declaring a new variable here meant that changes to the assets was leaking between tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
+ Coverage 82.47% 82.51% +0.03%
==========================================
Files 279 279
Lines 14446 14477 +31
==========================================
+ Hits 11915 11946 +31
Misses 2028 2028
Partials 503 503 ☔ View full report in Codecov by Sentry. |
| } | ||
| }, | ||
| "kin": { | ||
| "5a5ccef6-8daa-4cb8-8e52-6b486361710f": { |
There was a problem hiding this comment.
here we have a translation for the second component but not the first - the final template_variables translation needs to borrow values for the first component from the original language
| @@ -32,19 +32,11 @@ const TypeSendMsg string = "send_msg" | |||
| // "text": "Hi @contact.name, are you ready to complete today's survey?", | |||
| // "attachments": [], | |||
| // "all_urns": false, | |||
| // "templating": { | |||
There was a problem hiding this comment.
we could just go back to the 13.3 format of a templating object with a UUID and a list of variables.. but I never liked having an arbitrary UUID on a thing just so it could be localized... so I'm putting template and template_variables directly on the action object.
No description provided.