Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input cleaning take 2 #1178

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Input cleaning take 2 #1178

merged 4 commits into from
Aug 18, 2023

Conversation

rowanseymour
Copy link
Member

Add InputCollation to envs and have router case tests (including location tests) use envs.CollateEquals

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1178 (dba3fc1) into main (c3696a4) will increase coverage by 0.00%.
The diff coverage is 90.76%.

@@           Coverage Diff           @@
##             main    #1178   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files         259      259           
  Lines       10970    10965    -5     
=======================================
- Hits         9633     9629    -4     
  Misses        918      918           
+ Partials      419      418    -1     
Files Changed Coverage Δ
flows/field.go 62.34% <33.33%> (ø)
flows/environment.go 84.61% <60.00%> (ø)
envs/locations.go 86.07% <80.00%> (-1.11%) ⬇️
envs/collate.go 100.00% <100.00%> (ø)
envs/environment.go 97.18% <100.00%> (ø)
flows/inputs/msg.go 91.83% <100.00%> (ø)
flows/routers/cases/tests.go 93.75% <100.00%> (-0.07%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rowanseymour rowanseymour merged commit ee18400 into main Aug 18, 2023
7 checks passed
@rowanseymour rowanseymour deleted the input_cleaning_take2 branch August 18, 2023 20:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant