Merge pull request #1270 from nyaruka/airtime_failure_tweak

Use empty value for airtime failure result
nyaruka · Jun 12, 2024 · e70af4b · e70af4b
2 parents 84e49a4 + b302e09
commit e70af4b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/flows/actions/testdata/transfer_airtime.json b/flows/actions/testdata/transfer_airtime.json
@@ -31,7 +31,7 @@
                 "created_on": "2018-10-18T14:20:30.000123456Z",
                 "step_uuid": "59d74b86-3e2f-4a93-aece-b05d2fdcde0c",
                 "name": "Reward Transfer",
-                "value": "0",
+                "value": "",
                 "category": "Failure"
             }
         ],
@@ -327,7 +327,7 @@
                 "created_on": "2018-10-18T14:20:30.000123456Z",
                 "step_uuid": "59d74b86-3e2f-4a93-aece-b05d2fdcde0c",
                 "name": "Reward Transfer",
-                "value": "0",
+                "value": "",
                 "category": "Failure"
             }
         ],

diff --git a/flows/actions/transfer_airtime.go b/flows/actions/transfer_airtime.go
@@ -100,7 +100,7 @@ func (a *TransferAirtimeAction) saveSuccess(run flows.Run, step flows.Step, tran
 }
 
 func (a *TransferAirtimeAction) saveFailure(run flows.Run, step flows.Step, logEvent flows.EventCallback) {
-	a.saveResult(run, step, a.ResultName, "0", CategoryFailure, "", "", nil, logEvent)
+	a.saveResult(run, step, a.ResultName, "", CategoryFailure, "", "", nil, logEvent)
 }
 
 // Results enumerates any results generated by this flow object