Rework syncx.Batcher so that it flushes a batch without waiting if it has enough items
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has enough items
rowanseymour
force-pushed
the
better_batcher
branch
from
f22225a
to
96c5b09
Compare
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 91.60% 91.89% +0.29%
==========================================
Files 35 35
Lines 1655 1678 +23
==========================================
+ Hits 1516 1542 +26
+ Misses 105 103 -2
+ Partials 34 33 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
norkans7
approved these changes
Aug 29, 2023
norkans7
approved these changes
Aug 30, 2023
rowanseymour
force-pushed
the
better_batcher
branch
from
bfd49e1
to
f34ace1
Compare
norkans7
approved these changes
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for example courier has 1000 msg statuses queued, batcher shouldn't wait to hit timeout.. should just process those 1000.