-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor urns
package
#119
Conversation
// NewFirebaseURN returns a URN for the passed in firebase identifier | ||
func NewFirebaseURN(identifier string) (URN, error) { | ||
return NewURNFromParts(FCMScheme, identifier, "", "") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we only created constructors for some schemes.. and we don't need them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those were used in courier but we can update courier to use NewURNFromParts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or as it is most common to not have a query
and display
for the URN can we have a short cut that we pass the scheme
type and the path
and that set the query
and display
to ""
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added that as urns.New(scheme, path)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
- Coverage 90.35% 89.81% -0.55%
==========================================
Files 41 42 +1
Lines 1991 1954 -37
==========================================
- Hits 1799 1755 -44
- Misses 154 160 +6
- Partials 38 39 +1 ☔ View full report in Codecov by Sentry. |
af69a1d
to
e8695b3
Compare
b4340ad
to
cd756a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we could also update the go version to 1.22
Trying to...
Normalize
because only at parse time do we typically have the right country code.