Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the mock for the URL with query if none matched specifically with… #115

Closed
wants to merge 1 commit into from

Conversation

norkans7
Copy link
Contributor

… the params

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (219c5e9) 90.05% compared to head (e3317dd) 90.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   90.05%   90.38%   +0.32%     
==========================================
  Files          41       41              
  Lines        1991     1996       +5     
==========================================
+ Hits         1793     1804      +11     
+ Misses        160      154       -6     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkans7 norkans7 force-pushed the allow-matching-url-ignore-params branch from 88b217d to e3317dd Compare February 15, 2024 09:44
Copy link
Member

@rowanseymour rowanseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not convinced we need this now that URLs can have wildcards... and I think I'd prefer to stick with the simplicity of that

@rowanseymour rowanseymour deleted the allow-matching-url-ignore-params branch March 1, 2024 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants