Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebSocket functionality to httpx #108

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Add WebSocket functionality to httpx #108

merged 4 commits into from
Jan 12, 2024

Conversation

rowanseymour
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (ac4221c) 90.88% compared to head (366930e) 89.93%.

Files Patch % Lines
httpx/websocket.go 71.73% 23 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   90.88%   89.93%   -0.95%     
==========================================
  Files          38       39       +1     
  Lines        1766     1858      +92     
==========================================
+ Hits         1605     1671      +66     
- Misses        127      150      +23     
- Partials       34       37       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour marked this pull request as ready for review January 12, 2024 15:36
@rowanseymour rowanseymour changed the title Add websocket struct to httpx Add WebSocket functionality to httpx Jan 12, 2024
@rowanseymour rowanseymour merged commit 842f638 into main Jan 12, 2024
3 checks passed
@rowanseymour rowanseymour deleted the websockets branch January 12, 2024 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant