Merge pull request #631 from nyaggah/feat/first-run

feat(cli): if else instead of ternary
nyaggah · Dec 10, 2024 · ddac0c4 · ddac0c4
2 parents 1ab3c0e + b8be7c0
commit ddac0c4
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 3 deletions.
diff --git a/.changeset/great-rules-knock.md b/.changeset/great-rules-knock.md
@@ -0,0 +1,6 @@
+---
+'overlay-react-ts': patch
+'@bedframe/cli': patch
+---
+
+in/else instead of ternary
diff --git a/examples/overlay-react-ts/src/scripts/content.tsx b/examples/overlay-react-ts/src/scripts/content.tsx
@@ -17,7 +17,11 @@ export const frameConfig: FrameConfig = {
 
 export function mountOrUnmountIframe(): void {
   const FrameId = (frameConfig.iframe as { id: string }).id
-  document.getElementById(FrameId) === null ? mountFrame() : unmountIframe()
+  if (document.getElementById(FrameId) === null) {
+    mountFrame()
+  } else {
+    unmountIframe()
+  }
 }
 
 export function openOrCloseExtension(): void {

diff --git a/packages/cli/public/stubs/scripts/content.tsx b/packages/cli/public/stubs/scripts/content.tsx
@@ -17,7 +17,11 @@ export const frameConfig: FrameConfig = {
 
 export function mountOrUnmountIframe(): void {
   const FrameId = (frameConfig.iframe as { id: string }).id
-  document.getElementById(FrameId) === null ? mountFrame() : unmountIframe()
+  if (document.getElementById(FrameId) === null) {
+    mountFrame()
+  } else {
+    unmountIframe()
+  }
 }
 
 export function openOrCloseExtension(): void {

diff --git a/packages/cli/src/lib/make/utils/write-package-json.ts b/packages/cli/src/lib/make/utils/write-package-json.ts
@@ -97,7 +97,7 @@ export function writePackageJson(response: prompts.Answers<string>): void {
     }
   },
   "devDependencies": {
-    "@bedframe/cli": "0.0.89",
+    "@bedframe/cli": "0.0.90",
     "@bedframe/core": "0.0.44",
 ${
   changesets