Skip to content

Commit

Permalink
Update all dependencies 🌴 (#369)
Browse files Browse the repository at this point in the history
* chore(package): update dependencies

https://greenkeeper.io/

* Updated some usage

* Fix _.template and semver usage
  • Loading branch information
greenkeeperio-bot authored and adam-lynch committed Oct 9, 2016
1 parent 0ba5123 commit b52be49
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 12 deletions.
2 changes: 1 addition & 1 deletion lib/Version.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module.exports = function Version(args){
var platformUrls = {};
supportedPlatforms.forEach(function (supportedPlatform) {
flavors.forEach(function(flavor) {
platformUrls[supportedPlatform + '-' + flavor] = args.downloadUrl + _.template(platforms[supportedPlatform].versionNameTemplate, result);
platformUrls[supportedPlatform + '-' + flavor] = args.downloadUrl + _.template(platforms[supportedPlatform].versionNameTemplate)(result);
});
});
return platformUrls;
Expand Down
2 changes: 1 addition & 1 deletion lib/versions.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function getLegacyVersions(downloadUrl, flavor){
// scrapes valid semver versions from apache directory listing
while ((searchRes = scrapePtrn.exec(body)) !== null) {
searchRes = searchRes[1];
if( semver.valid(searchRes) && !_.contains(versions, searchRes) ) {
if( semver.valid(searchRes) && !_.includes(versions, searchRes) ) {
versions.push(searchRes);
}
}
Expand Down
16 changes: 9 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,33 +37,35 @@
"application"
],
"devDependencies": {
"eol": "~0.3.0",
"nock": "^8.0.0",
"tape": "~4.6.2",
"redtape": "~1.0.0",
"eol": "~0.2.0"
"tap-spec": "^4.1.1"
},
"dependencies": {
"archiver": "^1.0.0",
"bluebird": "^3.4.0",
"decompress-zip": "0.3.0",
"deprecate": "~0.1.0",
"deprecate": "~1.0.0",
"graceful-fs-extra": "^2.0.0",
"graceful-ncp": "^3.0.0",
"inherits": "~2.0.1",
"lodash": "~2.4.1",
"lodash": "~4.16.2",
"optimist": "^0.6.1",
"platform-overrides": "~1.0.1",
"plist": "^1.0.0",
"plist": "^2.0.1",
"progress": "~1.1.7",
"rcedit": "^0.5.0",
"rcedit": "^0.7.0",
"recursive-readdir-sync": "^1.0.6",
"request": "^2.74.0",
"request": "~2.75.0",
"rimraf": "^2.5.2",
"semver": "^2.3.2",
"simple-glob": "~0.1.0",
"tar-fs": "^1.13.0",
"temp": "~0.7.0",
"update-notifier": "^0.7.0",
"update-notifier": "^1.0.2",
"winresourcer": "^0.9.0"
}
}

2 changes: 1 addition & 1 deletion test/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ test('should zip the app and create the app.nw file + log it', function (t) {
}, {
"src" : path.normalize("test/fixtures/nwapp/package.json"),
"dest": path.normalize("package.json")
}], expected = _.pluck(files, 'dest').sort();
}], expected = _.map(files, 'dest').sort();

var _evt = new EventEmitter();
_evt.on('log', function (logging) {
Expand Down
6 changes: 4 additions & 2 deletions test/versions.js
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,7 @@ test('getVersion (legacy)', function (t) {
versions.getVersion({
desiredVersion: '0.10.2',
downloadUrl:'http://dl.nwjs.io/',
flavor:'sdk'

flavor:'sdk'
}).then(function(result){
t.equal(result.version, '0.10.2');
t.equal(result.name, 'node-webkit');
Expand All @@ -306,6 +305,9 @@ test('getVersion (legacy)', function (t) {
'win32-sdk': 'http://dl.nwjs.io/v0.10.2/node-webkit-v0.10.2-win-ia32.zip',
'win64-sdk': 'http://dl.nwjs.io/v0.10.2/node-webkit-v0.10.2-win-x64.zip'
});
})
.catch(function(err){
t.end(err);
});
});

Expand Down

0 comments on commit b52be49

Please sign in to comment.