Skip to content

Commit

Permalink
fix(utils): do not append Version before `CFBundleShortVersionStrin…
Browse files Browse the repository at this point in the history
…g` (#576)

* fix(utils): do not append `Version` before `CFBundleShortVersionString`

* fix(tests): remove `Version` from tests

* chore(docs): update changelog
  • Loading branch information
ayushmanchhabra authored Jun 3, 2022
1 parent f8696ae commit 6282f27
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .github/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## Removed

- Remove `Version` from `CFBundleShortVersionString` [#576](https://github.com/nwjs-community/nw-builder/pull/576)

## [3.7.2] - 2022-06-02

## Added
Expand Down
2 changes: 1 addition & 1 deletion lib/utils.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ module.exports = {
}
if (parsedParams.version) {
obj.CFBundleVersion = parsedParams.version;
obj.CFBundleShortVersionString = "Version " + parsedParams.version;
obj.CFBundleShortVersionString = parsedParams.version;
}
if (parsedParams.copyright) {
obj.NSHumanReadableCopyright = parsedParams.copyright;
Expand Down
2 changes: 1 addition & 1 deletion test/expected/osx-plist/1.plist
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>Version 1.3.3.7</string>
<string>1.3.3.7</string>
<key>CFBundleVersion</key>
<string>1.3.3.7</string>
<key>LSFileQuarantineEnabled</key>
Expand Down
2 changes: 1 addition & 1 deletion test/expected/osx-plist/2.plist
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>Version 1.3.3.7</string>
<string>1.3.3.7</string>
<key>CFBundleVersion</key>
<string>1.3.3.7</string>
<key>LSFileQuarantineEnabled</key>
Expand Down

0 comments on commit 6282f27

Please sign in to comment.