fix: fix GitHub API request

nwtgck · Mar 5, 2020 · 1a696fe · 1a696fe · github-actions · Mar 5, 2020
1 parent 0ab16ef
commit 1a696fe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/backend/src/infra/DefaultGitHubApiService.ts b/backend/src/infra/DefaultGitHubApiService.ts
@@ -17,6 +17,7 @@ export class DefaultGitHubApiService implements GitHubApiService {
     if (jsonStr === undefined) {
       this.logger.info(`Repository JSON ${repoName} is not cached`);
 
+      let query = '';
       const headers= (() => {
         if (this.githubCredential === undefined) {
           return {};
@@ -26,11 +27,12 @@ export class DefaultGitHubApiService implements GitHubApiService {
             // Basic Auth
             "Authorization": `Basic: ${Buffer.from(`${githubClientId}:${githubClientSecret}`).toString("base64")}`,
           };
+          query = `?client_id=${githubClientId}&client_secret=${githubClientSecret}`;
           return h;
         }
       })();
 
-      const githubRes = await fetch(`https://api.github.com/repos/${repoName}`, {
+      const githubRes = await fetch(`https://api.github.com/repos/${repoName}${query}`, {
         headers,
       });
       if (githubRes.status !== 200) {

diff --git a/backend/src/route.ts b/backend/src/route.ts
@@ -57,6 +57,7 @@ export function createServer(
     const repoResult = await gitHubApiService.getRepository(`${repoName}`);
 
     if ("status" in repoResult) {
+      logger.error(`GitHub API error: ${JSON.stringify(repoResult)}`);
       if (repoResult.status === 404) {
         res.status(404);
         res.send(`${repoName} not found\n`);