Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private policy #179

Merged
merged 5 commits into from
Nov 19, 2023
Merged

private policy #179

merged 5 commits into from
Nov 19, 2023

Conversation

samanthatuhseng
Copy link
Contributor

@samanthatuhseng samanthatuhseng commented Nov 16, 2023

Description

Issue: #178

This PR adds a new privacy.js page to our application, which contains our updated privacy policy. It provides users with detailed information about the data we collect, how we use it, and their rights regarding their data.

Changes made:

  • Added a new privacy.js page.
  • Included sections for key points, preface, terminology, data collection, data sharing, and user rights.
  • put each section with relevant content regarding our privacy policy.

Other considerations

possible future changes: consistency and design

Copy link

github-actions bot commented Nov 16, 2023

Visit the preview URL for this PR (updated for commit 22baf71):

https://nwplus-io--pr179-private-policy-p5o4h871.web.app

(expires Sun, 26 Nov 2023 04:57:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a778397fecec2eb8f19e28d7b9fa723113d13f3d

Copy link
Contributor

@michelleykim michelleykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for getting this done so quickly! It seems like the header overlaps with the content on privacy page, wondering if it's just me or do you also see this?
image

@meleongg
Copy link
Member

I also see the weird overlap -> I think the nwHacks apps closed banner needs to be there

@michelleykim michelleykim self-requested a review November 17, 2023 17:23
Copy link
Contributor

@michelleykim michelleykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i think we're good to merge once pres give thumbs up

@michelleykim michelleykim merged commit 9bfa8aa into main Nov 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants