conditional disable button #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit bc911e6): https://nwplus-io--pr132-phoenix-live-portal-beb8lkcd.web.app (expires Mon, 29 Nov 2021 01:20:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
panjenny0
reviewed
Nov 16, 2021
components/NavBar.js
Outdated
Comment on lines
155
to
159
| ${(p) => | ||
| p.disabled && | ||
| `&:hover { | ||
| cursor: not-allowed; | ||
| } | ||
| }`} |
There was a problem hiding this comment.
I took a look at the preview link and the button is still disabled. A few suggestions:
- there could be a race condition between when the
isLiveflag is set and when theLivePortalButtonis rendered. I suggest settingisLivetonullby default in theuseState, then only rendering theLivePortalButtonwhenisLivehas been set (i.e.{isLive !== null && <LivePortalButton ... />}) - a side note:
livePortalLinkis undefined when I run your branch locally - where is this collection being stored? might want to check if this is a field or a collection and if we're fetching from the right place. - minor UX enhancement: move the conditional
p.disabledinside the hover pseudo class. For disabled=true, set cursor =not-allowed, otherwise set it topointer- (i.e.
p.disabled ? 'not-allowed' : 'pointer'
- (i.e.
There was a problem hiding this comment.
Lmk if you need any clarification. Also feel free to ping me if you want to pair on this!
There was a problem hiding this comment.
- live portal button is now only rendered when isLive is pulled from firebase
livePortalLinkno longer exists and I'll address this in another CMS ticket CMS: Add field to modify live portal link #133- conditionally change the pointer style done
kevin-zou
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
conditionally disable cursor for live portal
Other considerations
@panjenny0