Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect fix #621

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Redirect fix #621

merged 1 commit into from
Oct 19, 2024

Conversation

martincai8
Copy link
Contributor

@martincai8 martincai8 commented Oct 19, 2024 •
edited
Loading

Description

  • changed the redirect behaviour so if a user logs in and they haven't been accepted + rsvp'ed, then they'll get redirected to the application page
  • set the activeHackathon in local storage again after changing routes (it's already in the provider, but this redundancy makes it more reliable)
  • added a bg so our homepage is spicier 🚀

Other considerations

@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit 48f1161):

https://nwplus-ubc--pr621-redirect-fix-942zl13w.web.app

(expires Sat, 26 Oct 2024 08:20:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48

@martincai8 martincai8 merged commit 11f3d83 into main Oct 19, 2024
2 checks passed
@martincai8 martincai8 deleted the redirect-fix branch October 19, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdanielles tdanielles tdanielles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martincai8 @tdanielles