-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: event API #181
base: main
Are you sure you want to change the base?
feat!: event API #181
Conversation
Apologies for commenting here but are we providing |
@231tr0n The goal is to give full control over on what events what should happen. |
Ohh so lint_on_save, fmt_on_save and save_on_fmt are no more a thing is it? |
I think I will keep the existing options as nice deafults. |
Just a suggestion but I think it would be better to probably remove these options and let users decide when to format and lint and just provide One more thing is if we are going to keep the options, then might as well provide |
Yeah I guess it makes sense. Will call it |
Reminder to self:
|
Need to rewrite the whole event module, will take a while to land |
Add event API to provide control to guard autocmds.
events
field in tool configauto_lint
optionGuard lint
Guard disable
->Guard disable-fmt
Guard enable
->Guard enable-fmt
Guard disable-lint
Guard enable-lint