feat: use generate_note_filename for renaming notes

[onemoresuza]

Proposed change

This PR makes so that generate_filename_note is used when renaming notes.

It is now possible to go from a uuid-title/title-uuid to title or uuid or the
other way around -- note that when going from uuid to uuid-title/title-uuid the
old uuid will be used as a title and a new uuid will be created.

It is not possible going from title-uuid to uuid-title or vice-versa, since the
current implementation will consider the old title the new uuid and the old uuid
the new title.

In all cases in which the new implementation is unable to succeed, manual
renaming of the files will be needed.

The following breaking changes are introduced:

1. Telekasten rename_note now passes only the filename without the uuid for
   the user to edit, while now being affected by filename_space_subst.

Type of change

• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Code quality improvements to existing code or addition of tests
• Documentation update

Additional information

• This PR fixes or closes issue: fixes [BUG] rename-note doesn't use title config #138

Checklist

• I am running the latest version of the plugin.
• The code change is tested and works locally.
• There is no commented out code in this PR.
• The code has been formatted using Stylua (a .stylua.toml file is provided)
• The code has been checked with luacheck (a .luacheckrc file is provided)
• The README.md has been updated according to this change.
• The doc/telekasten.txt helpfile has been updated according to this change.

[lambtho12]

I do not really understand the sepsubst stuff. Could you explain a bit more the logic ?

[onemoresuza]

I do not really understand the sepsubst stuff. Could you explain a bit more the logic ?

Sure.

It's to ensure that there's only one uuid_sep on the filename. For instance, for a config that has either uuid-title or title-uuid for new_note_filename, when the user calls Telekasten new_note and types my-note-name the filename shall be:

my_note_name-<uuid>

This ensures that the uuid may be retrieved regardless of what is in uuid_type.

[lambtho12]

I am not a fan of overwriting stuff like that. If the user types the hyphens on purpose, it is reasonable to assume that they want the hyphens and not something else. I feel that this may cause more complaints than anything.

Couldn't we just find the UUID part using some regexes based uuid_type and uuid_sep instead ?

[onemoresuza]

We can:

> title_uuid = "name-with-hifens-uuid12"
> uuid_title = "uuid12-name-with-hifens"
> print(title_uuid:match("^(.+)%-(.-)$"))
name-with-hifens	uuid12
> print(uuid_title:match("^(.-)%-(.+)$"))
uuid12	name-with-hifens

Going to update the PR.

[onemoresuza]

@lambtho12, I've implemented the regexes based on uuid_type and uuid_sep.

[lambtho12]

Great addition. Thank you very much for this PR and for your patience.

If you have some time, you are welcome to work on other opened issues, its always great to see people getting involved when I have very little time to move this project forward myself 😄