feat!: luarocks build backend / compatibility layer #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcjkb
force-pushed
the
mj/push-vwkrwryqvsrk
branch
from
8da4911 to
1569194
Compare
mrcjkb
force-pushed
the
mj/push-ulzzwstwyozu
branch
from
ecd78aa to
9b7741d
Compare
mrcjkb
force-pushed
the
mj/push-vwkrwryqvsrk
branch
2 times, most recently
from
858c5e7 to
43e966c
Compare
mrcjkb
force-pushed
the
mj/push-ulzzwstwyozu
branch
from
843b300 to
73766f3
Compare
mrcjkb
force-pushed
the
mj/push-vwkrwryqvsrk
branch
8 times, most recently
from
5f78f6e to
a61e2cc
Compare
mrcjkb
force-pushed
the
mj/push-vwkrwryqvsrk
branch
5 times, most recently
from
73f561c to
6fc34f3
Compare
mrcjkb
force-pushed
the
mj/push-vwkrwryqvsrk
branch
from
6fc34f3 to
5681236
Compare
mrcjkb
commented
Dec 14, 2024
mrcjkb
force-pushed
the
mj/push-vwkrwryqvsrk
branch
from
5681236 to
2e39ada
Compare
mrcjkb
force-pushed
the
mj/push-vwkrwryqvsrk
branch
from
2e39ada to
70c3fa9
Compare
mrcjkb
changed the title
vhyrro
approved these changes
Dec 17, 2024
Comment on lines
+30
to
+47
| pub(crate) fn recursive_copy_dir(src: &PathBuf, dest: &Path) -> Result<(), io::Error> { | ||
| if src.exists() { | ||
| for file in walkdir::WalkDir::new(src) | ||
| .into_iter() | ||
| .flatten() | ||
| .filter(|file| file.file_type().is_file()) | ||
| { | ||
| let relative_src_path: PathBuf = | ||
| pathdiff::diff_paths(src.join(file.clone().into_path()), src) | ||
| .expect("failed to copy directories!"); | ||
| let filepath = file.path(); | ||
| let target = dest.join(relative_src_path); | ||
| std::fs::create_dir_all(target.parent().unwrap())?; | ||
| std::fs::copy(filepath, target)?; | ||
| } | ||
| } | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
nit(for a different PR): I believe we already vendor (or wanted to vendor) a library that has a recursive copy function with the ability to add globs to customize the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is a breaking change, as rocks are now installed in a
treesubdirectory of the rocks data directory.This PR's implementation assumes that luarocks build backends don't use other custom build backends to build,
which I think is a pretty safe assumption.