-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]: Implement an install script for rocks.nvim
#30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Do we need to configure luarocks to use the rocks-binaries so that rocks.nvim can update itself?
Otherwise, users would have to have the rust and C++ toolchains installed, wouldn't they?
Yep, without the binary rocks users would need to have a modern CPP compiler and rust tool chain. If luarocks can't find the binary rock for the target architecture it'll try compiling instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
How could we do that? Since it is the dependencies that we want to extract from rocks-binaries and not the complete package 🤔 |
Maybe we have to specify the dependencies separately - or we can add rocks.nvim to the rocks-binaries manifest, but not as a binary. And add a |
Not sure if I understand the questions being asked here - the server that we configure is is simply the preferred server. When luarocks tries to pull in |
That's the install script. What about updates? I don't think we specify |
Ah you're right. I was certain I also added that, but apparently I didn't. All rocks operations should also pass the |
Hm, weird. I guess it has to do with some calculations that the installer is making. Let me see if I can fix that. |
Should be fixed now! :D |
…e numbers and other obstructions
This PR adds a fully working installation process using a remote
:source
command invocation.While there are still a few rough edges I believe it's a good enough MVP to push into main :)