Add ability to format tabs with highlights #1098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slotos
force-pushed
the
tabs-highlight-formatting
branch
from
777abbd to
297368b
Compare
Slotos
force-pushed
the
tabs-highlight-formatting
branch
from
297368b to
19b7294
Compare
|
Rebased the changes on top of master. |
This adds a handling of optional `fmt` return value that is a table of
`{highlight = "*", name = "*"}` or `{name = "*"}` tables. The primary
goal is to have highlights not count to the visible character limit.
Without it, attempts to format the tab name with highlights cause nearly
immediate ellipsification.
Due to crossbleed in the test setup, a buffers component test was also
updated to test through _buffer_ commands. Frankly, when using
bufferline, one should forget about tab commands, as the real state of
vim windows is hidden and unpredictable.
Mode handling had been forced to not interact with table processing at
all. If user provides a detailed table, they are assumed to be in
control.
Slotos
force-pushed
the
tabs-highlight-formatting
branch
from
19b7294 to
d349268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a handling of optional
fmtreturn value that is a table of{highlight = "*", name = "*"}or{name = "*"}tables. The primary goal is to have highlights not count to the visible character limit. Without it, attempts to format the tab name with highlights cause nearly immediate ellipsification.Due to crossbleed in the test setup, a buffers component test was also updated to test through buffer commands. Frankly, when using bufferline, one should forget about tab commands, as the real state of vim windows is hidden and unpredictable.
As an example of a practical outcome, with this it's possible to add colored devicons to a tabs tabline:
I am trying to keep this as dumb as possible, since windows and their users are inherently more complex than buffers, leading to various ways to usefully represent them that individual users would know best about.