Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1087): handle searchcount failures #1088

Merged

Conversation

alex-courtis
Copy link
Contributor

@alex-courtis alex-courtis commented Sep 3, 2023

fixes #1087

We could alert the user to the failure, however vim does that well enough.

Tested OK:

  • valid search - count populated and iterated properly
  • invalid search - no count

@alex-courtis
Copy link
Contributor Author

I'm not sure what to do about the nvim-web-devicons failures on 0.5 and 0.6

I added the nvim 0.7 minimum requirement ~2023 01 when we needed 0.7+ API

@shadmansaleh
Copy link
Member

looks good to me. thanks for your contribution

@shadmansaleh shadmansaleh merged commit 2248ef2 into nvim-lualine:master Oct 20, 2023
5 checks passed
craigmac pushed a commit to craigmac/lualine.nvim that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: repeated searchcount failure on invalid search string
2 participants