Fix couple bugs with multiple results and varargs (...) #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
vararg.rotate
, and bothfunctional.partial
andfun.bind
(which are the same), had couple mistakes. I'll mention the particular bugs in the diff. For a reference, see: https://www.lua.org/manual/5.4/manual.html#3.4.12.These fixes make the functions generally correct. Since these bugs have been there from the beginning, the real use is more limited (i.e. bind a single
(non nil)parameter, or rotate 1-16 arguments). So another valid fix would be to limit the generality to these already working cases.Let me know if that would be preferable.
Also let me know if there is some convention I've missed, or if you would like me to document this also on the issues.