Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(path): find_upwards() failure case is an infinite loop #506

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(path): find_upwards() failure case is an infinite loop #506

wants to merge 3 commits into from

Commits on Jul 3, 2023

  1. Fix Path:find_upwards() 

    The prior implementation had several implementation issues which caused
an infinite loop if the search turned up empty.

This new implementation corrects the bounds check to stop searching once
we've searched everywhere we can, and properly searches the root
directory
    @shreve
    shreve committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    46ee11a View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Revert change to Path:joinpath

    @shreve
    shreve committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    a47907e View commit details
    Browse the repository at this point in the history

  2. Add specs for Path:find_upwards

    @shreve
    shreve committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    8ae582d View commit details
    Browse the repository at this point in the history