Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using cudf_helpers.pyx to copy a cuDF DataFrame #1945

Closed
wants to merge 14 commits into from
Closed

Avoid using cudf_helpers.pyx to copy a cuDF DataFrame #1945

wants to merge 14 commits into from

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 15, 2024 •
edited
Loading

Description

  • Avoid calling CudfHelper::table_from_table_info to perform a copy of a cuDF, we're already holding the gil, so just call the DataFrame.copy method instead.
  • Requires making TableInfoBase::get_parent a public method

Closes #1934

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested review from a team as code owners October 15, 2024 19:53
@dagardner-nv dagardner-nv self-assigned this Oct 15, 2024
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: MessageMeta.copy_dataframe() causes SIGSEGV error with certain cudf dataframes
1 participant
@dagardner-nv