-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert partially constructed segments on-error in segment init function #407
Revert partially constructed segments on-error in segment init function #407
Conversation
…d issue isn't relevent to this test
This reverts commit 6914da7.
…s different builds of llvm packages to fix CI
…inconsistent-pipe
… into david-inconsistent-pipe
…inconsistent-pipe
…cond segments [no ci]
…nts check_active_connection from mistakenly returning true for a holder where init_owned_edge has been called but neither the init_connected_edge method or the add_connector method have not been called
…gressProvider" This reverts commit 111d7f8.
… has already been destroyed, avoid using the m_parent if the node has been destroyed
…inconsistent-segments-and-edges-named
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.11 #407 +/- ##
================================================
- Coverage 74.03% 73.84% -0.20%
================================================
Files 394 385 -9
Lines 13955 13710 -245
Branches 1053 1033 -20
================================================
- Hits 10332 10124 -208
+ Misses 3623 3586 -37
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 70 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Closing in favor of #434 |
Description
inner_edge
held by theForwardingEgressProvider
is disconnected.Fixes #360
Fixes #400
Fixes #401
Checklist