Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe handling of control plane promises #380

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Sep 8, 2023

Description

fixes #379

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working priority 0 DO NOT MERGE labels Sep 8, 2023
@dagardner-nv dagardner-nv requested a review from a team as a code owner September 8, 2023 00:01
@dagardner-nv dagardner-nv self-assigned this Sep 8, 2023
@dagardner-nv dagardner-nv requested a review from a team as a code owner September 8, 2023 18:38
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #380 (7a277cb) into branch-23.11 (9153243) will increase coverage by 0.07%.
The diff coverage is 88.73%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.11     #380      +/-   ##
================================================
+ Coverage         73.11%   73.18%   +0.07%     
================================================
  Files               382      382              
  Lines             13403    13447      +44     
  Branches           1010     1013       +3     
================================================
+ Hits               9799     9841      +42     
- Misses             3604     3606       +2     
Flag Coverage Δ
cpp 69.14% <88.73%> (+0.10%) ⬆️
py 41.95% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cpp/mrc/src/internal/control_plane/client.hpp 69.69% <76.19%> (+0.73%) ⬆️
cpp/mrc/src/internal/control_plane/client.cpp 71.07% <88.00%> (+0.98%) ⬆️
cpp/mrc/src/internal/grpc/promise_handler.hpp 100.00% <100.00%> (ø)
cpp/mrc/src/internal/grpc/server.cpp 93.33% <100.00%> (+5.45%) ⬆️
cpp/mrc/src/tests/test_control_plane.cpp 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9153243...7a277cb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DO NOT MERGE
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Intermittent test failures for clang & gcc-coverage
3 participants