Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke Python's gc prior to finalizing a thread #363

Closed

Conversation

dagardner-nv
Copy link
Contributor

Description

fixes #362

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #363 (50abe96) into branch-23.11 (9b47924) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-23.11     #363   +/-   ##
=============================================
  Coverage         73.11%   73.12%           
=============================================
  Files               382      382           
  Lines             13403    13408    +5     
  Branches           1010     1010           
=============================================
+ Hits               9800     9804    +4     
- Misses             3603     3604    +1     
Flag Coverage Δ
cpp 69.06% <100.00%> (+0.01%) ⬆️
py 42.07% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...pp/mrc/src/internal/segment/builder_definition.cpp 83.53% <100.00%> (+0.30%) ⬆️
python/mrc/_pymrc/src/executor.cpp 54.46% <100.00%> (-0.09%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b47924...50abe96. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DO NOT MERGE non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Python thread finalizer can cause thread-local storage to be cleared prematurely in some situations
1 participant