Skip to content

Commit

Permalink
Fix a few minor type-o's in comments (#332)
Browse files Browse the repository at this point in the history
* Replace references to `TaggedManager` with `TaggedIssuer`
* Ran across these while reading up on control plane

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #332
  • Loading branch information
dagardner-nv authored Jun 20, 2023
1 parent 23997bf commit 0d0ab70
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cpp/mrc/src/internal/control_plane/server.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ void Server::do_service_await_join()
/**
* @brief Stream Acceptor
*
* The while loop of this method says active as long as the grpc server is still accepting connections.
* The while loop of this method stays active as long as the grpc server is still accepting connections.
* There are multiple way this can be implemented depending the service requirements, one might choose
* to preallocate N number of streams and issues them all to the CQ. This is an alternative method which
* creates a single stream and waits for it to get initialized, then creates another. The current implementation is
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class Role;
class ClientInstance;

/**
* @brief A specialize TaggedManager to synchronize tag and instance_id information across between a collection of
* @brief A specialized TaggedIssuer to synchronize tag and instance_id information across between a collection of
* client-side objects with common linkages, e.g. the Publisher/Subscriber services which form the building blocks for
* Ingress/EgressPorts use instances of SubscriptionService for Publishers to get control plane updates to the list of
* Subscribers.
Expand Down
4 changes: 2 additions & 2 deletions cpp/mrc/src/internal/control_plane/server/tagged_issuer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ class Tagged
* This is the primary base class for a control plane server-side stateful service which can be updated by the client
* and state updates driven independently via the issue_update() method.
*
* TaggedManager is not thread-safe or protected in anyway. The global state mutex should protect all TaggedManagers.
* TaggedIssuer is not thread-safe or protected in anyway. The global state mutex should protect all TaggedIssuers.
*
* In most scenarios, the service side will have a batched updated which will periodically visit each TaggedManager and
* In most scenarios, the service side will have a batched updated which will periodically visit each TaggedIssuer and
* call issue_update(); however, depending on the service request/update message, the call may also require an immediate
* update.
*/
Expand Down

0 comments on commit 0d0ab70

Please sign in to comment.