Adding python-only implementation of gradient + test #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipdemes
added
the
category:task
ipdemes
force-pushed
the
gradient
branch
3 times, most recently
from
d05be08 to
faf4f81
Compare
ipdemes
force-pushed
the
gradient
branch
6 times, most recently
from
421acef to
4e24ced
Compare
ipdemes
changed the title
manopapad
approved these changes
May 22, 2024
cunumeric/module.py
Outdated
Comment on lines
6835
to
6838
| # if distances are constant reduce to the scalar case | ||
| # since it brings a consistent speedup | ||
| if (diffx == diffx[0]).all(): | ||
| diffx = diffx[0] |
There was a problem hiding this comment.
Let's remove this "optimization". It causes blocking in cuNumeric, and if the user wanted constant spacing they should have just provided a constant here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.