Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logical_and reduction #1123

Merged
merged 7 commits into from
Mar 9, 2024
Merged

logical_and reduction #1123

merged 7 commits into from
Mar 9, 2024

Conversation

JosephGuman
Copy link

Adding logical_and.reduce() functionality by using existing reduction code for products and applying to booleans.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 7, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rohany rohany requested a review from manopapad February 7, 2024 23:58
manopapad
manopapad reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@manopapad manopapad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @JosephGuman!

tests/integration/test_logical_reduction.py Outdated Show resolved Hide resolved
tests/integration/test_logical_reduction.py Outdated Show resolved Hide resolved
cunumeric/_ufunc/ufunc.py Show resolved Hide resolved
@manopapad
Copy link
Contributor

/ok to test

@JosephGuman JosephGuman marked this pull request as draft February 8, 2024 19:48
@JosephGuman
Copy link
Author

Hello @manopapad Could you add the new-feature tag to this PR? I don't believe I have permissions to do this.

@manopapad manopapad added the category:new-feature PR introduces a new feature and will be classified as such in release notes label Feb 8, 2024
@manopapad
Copy link
Contributor

/ok to test

@manopapad manopapad mentioned this pull request Feb 14, 2024
Open
22 tasks
@marcinz marcinz changed the base branch from branch-24.01 to branch-24.03 February 22, 2024 01:03
@manopapad
Copy link
Contributor

/ok to test

@manopapad
Copy link
Contributor

@JosephGuman is this good for another round of reviews?

@JosephGuman
Copy link
Author

Hello, @manopapad I'm a little confused on the build error reported in the current test. It seems like there's some issue with cunumeric.digitize, but all the tests work fine locally. Do you know what might be the problem here?

@manopapad
Copy link
Contributor

/ok to test

@manopapad
Copy link
Contributor

Hello, @manopapad I'm a little confused on the build error reported in the current test. It seems like there's some issue with cunumeric.digitize, but all the tests work fine locally. Do you know what might be the problem here?

This is an issue with the documentation build, that has been fixed in the main branch. I merged from branch-24.03, so the CI should pass now.

@JosephGuman JosephGuman marked this pull request as ready for review February 28, 2024 19:44
@manopapad
Copy link
Contributor

/ok to test

@manopapad manopapad merged commit 9ece0a3 into nv-legate:branch-24.03 Mar 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohany rohany rohany left review comments

@manopapad manopapad manopapad approved these changes

Assignees
No one assigned
Labels
category:new-feature PR introduces a new feature and will be classified as such in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JosephGuman @manopapad @rohany