Gh docker reusable with tests #1022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepd-nv
added
in progress
category:task
sandeepd-nv
force-pushed
the
gh_docker_reusable_with_tests
branch
3 times, most recently
from
542757a to
d795c9a
Compare
sandeepd-nv
force-pushed
the
gh_docker_reusable_with_tests
branch
from
cecf934 to
ffc55f8
Compare
sandeepd-nv
force-pushed
the
gh_docker_reusable_with_tests
branch
from
ffc55f8 to
74efc4e
Compare
sandeepd-nv
force-pushed
the
gh_docker_reusable_with_tests
branch
3 times, most recently
from
2485636 to
59bcb1e
Compare
|
I see a build failure, right? |
marcinz
reviewed
Sep 5, 2023
| volumes: | ||
| - ${{ github.workspace }}/test_logs:/home/coder/.test_logs | ||
| env: | ||
| PYTHONDONTWRITEBYTECODE: 1 |
There was a problem hiding this comment.
I don't remember why do we need this one.
| set -eo pipefail | ||
| test-cunumeric ${{ inputs.test-options }} 2>&1 | tee ~/.test_logs/cunumeric-${{ inputs.sha }}-test-${{ inputs.log-name }}.log | ||
|
|
||
| - name: Upload logs |
There was a problem hiding this comment.
Why do we upload logs? The logs that are in the workflow are not enough?
This should be fixed when nv-legate/legate#830 is meged. |
|
nv-legate/legate#830 has been merged |
m3vaz
approved these changes
Sep 6, 2023
sandeepd-nv
force-pushed
the
gh_docker_reusable_with_tests
branch
from
59bcb1e to
ddc6e9a
Compare
|
Superseded by: #1043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.