Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lower case snippet directories #161

Closed
wants to merge 1 commit into from

Conversation

woldtwerk
Copy link

πŸ”— Linked issue / Discussion

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The dirs in package.json are lowercase. Dirs in Repo are Uppercase. This results in a lot of read file errors

Resolves #160

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@adhamfarrag
Copy link
Member

Hello @woldtwerk,

Just had the time to check and respond. Thanks for reporting #160 and working on the PR. ❀️ Had to refactor file naming in #166 and fix it myself with #167.

I feel bad for not using the PR and I'm very grateful you spent the time trying to fix this issue, but please let's just agree on a fix first and you're welcome to make any PR you find useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong directory casing
2 participants