Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better consent prompt, module event and fix logged command #103

Merged
merged 5 commits into from
Jul 5, 2023

Conversation

atinux
Copy link
Member

@atinux atinux commented Jul 5, 2023

  • Use consola.prompt instead of inquirer to support Y or N shortcut + select option
  • Show the correct command for now npx nuxt-telemetry until the new CLI is released
  • Added module event based on the installed dependencies (and we get the timings too!)

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Patch coverage: 79.31% and project coverage change: +8.30 🎉

Comparison is base (c803351) 75.65% compared to head (4e68d50) 83.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   75.65%   83.95%   +8.30%     
==========================================
  Files          18       18              
  Lines         645      586      -59     
  Branches       73       71       -2     
==========================================
+ Hits          488      492       +4     
+ Misses        156       94      -62     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
src/consent.ts 57.89% <33.33%> (-3.65%) ⬇️
src/events/module.ts 80.00% <80.00%> (ø)
src/telemetry.ts 71.87% <83.33%> (+5.20%) ⬆️
src/module.ts 97.34% <90.90%> (+0.07%) ⬆️
src/events/index.ts 100.00% <100.00%> (ø)
src/events/project.ts 100.00% <100.00%> (ø)
src/events/session.ts 69.23% <100.00%> (-30.77%) ⬇️
src/utils/log.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielroe danielroe changed the title chore: various improvements feat: better consent prompt, module event and fix logged command Jul 5, 2023
@danielroe danielroe merged commit 5e34507 into main Jul 5, 2023
@danielroe danielroe deleted the chore/improvements branch July 5, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants