ELEMENTS-1665: fix error/validation message when adding permission #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alokhyland
force-pushed
the
fix-ELEMENTS-1665-fix-error-validation-messag-when-adding-permission-3.1.x
branch
from
c138de7
to
d78fbf5
Compare
swarnadipa-dev
previously approved these changes
Sep 6, 2023
| @@ -284,6 +288,12 @@ import '../nuxeo-button-styles.js'; | |||
| this._doSend(true); | |||
| } | |||
|
|
|||
| doCancel() { | |||
| // get called when clicked on cancel button | |||
There was a problem hiding this comment.
No need to include comments when the code is self-explanatory.
ui/widgets/nuxeo-user-suggestion.js
Outdated
| /** | ||
| * Set to `true` for invalid. | ||
| */ | ||
| invalid: { |
There was a problem hiding this comment.
is this discussed with PO that we exposing a new property ?
There was a problem hiding this comment.
removed this changes as its not required
alokhyland
force-pushed
the
fix-ELEMENTS-1665-fix-error-validation-messag-when-adding-permission-3.1.x
branch
from
d78fbf5
to
e8a7615
Compare
alokhyland
force-pushed
the
fix-ELEMENTS-1665-fix-error-validation-messag-when-adding-permission-3.1.x
branch
from
e8a7615
to
6197ec4
Compare
alokhyland
changed the title
swarnadipa-dev
approved these changes
Sep 6, 2023
rakeshkumar1019
approved these changes
Sep 6, 2023
arupmmi07
approved these changes
Sep 6, 2023
alokhyland
deleted the
fix-ELEMENTS-1665-fix-error-validation-messag-when-adding-permission-3.1.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.