ELEMENTS-1665: Fix error/validation message when adding permission

nuxeo · Sep 1, 2023 · 0f70d30 · 0f70d30
1 parent 3cb8f45
commit 0f70d30
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/ui/nuxeo-document-permissions/nuxeo-popup-permission.js b/ui/nuxeo-document-permissions/nuxeo-popup-permission.js
@@ -106,6 +106,8 @@ import '../nuxeo-button-styles.js';
                   value="{{params.users}}"
                   placeholder="[[i18n('popupPermission.userGroup.placeholder')]]"
                   multiple
+                  required
+                  invalid="{{params.invalid}}"
                 >
                 </nuxeo-user-suggestion>
               </div>
@@ -192,7 +194,9 @@ import '../nuxeo-button-styles.js';
           </paper-dialog-scrollable>
 
           <div class="buttons">
-            <paper-button dialog-dismiss class="secondary">[[i18n('popupPermission.cancel')]]</paper-button>
+            <paper-button dialog-dismiss class="secondary" on-click="doCancel"
+              >[[i18n('popupPermission.cancel')]]</paper-button
+            >
             <dom-if if="{{!updatingACE}}">
               <template>
                 <paper-button noink class="primary small" on-click="doCreateAndAdd" id="createAndAddPermissionButton">
@@ -284,6 +288,12 @@ import '../nuxeo-button-styles.js';
       this._doSend(true);
     }
 
+    doCancel() {
+      // get called when clicked on cancel button
+      this.params = this._getResetParams();
+      this.set('params.invalid', false);
+    }
+
     _computeTitle() {
       if (this.updatingACE) {
         return this.i18n('popupPermission.updatePermission');
@@ -312,6 +322,7 @@ import '../nuxeo-button-styles.js';
         return;
       }
       if (!this.shareWithExternal && !this.params.username && (!this.params.users || this.params.users.length === 0)) {
+        this.set('params.invalid', true);
         return;
       }
 
@@ -428,6 +439,7 @@ import '../nuxeo-button-styles.js';
         end: null,
         notify: true,
         comment: '',
+        invalid: false,
       };
     }
   }

diff --git a/ui/widgets/nuxeo-user-suggestion.js b/ui/widgets/nuxeo-user-suggestion.js
@@ -232,6 +232,14 @@ import './nuxeo-user-group-formatter.js';
          * Results filtering function (optional).
          */
         queryResultsFilter: Function,
+
+        /**
+         * Set to `true` for invalid.
+         */
+        invalid: {
+          type: Boolean,
+          value: false,
+        },
       };
     }