Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nxdrive-2929: Upgrade Python from 3.9.5 to 3.12.3 #5195

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dead_code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/.cache/pip
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/functional_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/.cache/pip
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/Library/Caches/pip
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~\AppData\Local\pip\Cache
Expand Down Expand Up @@ -129,7 +129,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/.cache/pip
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/functional_tests_2023.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/.cache/pip
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/Library/Caches/pip
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~\AppData\Local\pip\Cache
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/.cache/pip
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
architecture: "x86"
- uses: actions/cache@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/.cache/pip
Expand Down
Empty file added .github/workflows/main.yml
Empty file.
2 changes: 1 addition & 1 deletion .github/workflows/spell.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/.cache/pip
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/style.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/.cache/pip
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/translations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/.cache/pip
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/types.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/.cache/pip
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/.cache/pip
Expand Down Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
- uses: actions/cache@v4
with:
path: ~/Library/Caches/pip
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9 # XXX_PYTHON
python-version: 3.12 # XXX_PYTHON
architecture: "x86"
- uses: actions/cache@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion docs/deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Executing the script without argument will setup.update the isolated environment

[//]: # (XXX_PYTHON, XXX_INNO_SETUP)

- [Python 3.9.5](https://www.python.org/ftp/python/3.9.5/python-3.9.5.exe).
- [Python 3.12.3](https://www.python.org/ftp/python/3.12.3/python-3.12.3.exe).
- [Inno Setup 6.1.2](http://www.jrsoftware.org/isdl.php) to create the installer.

### Troubleshooting
Expand Down
2 changes: 1 addition & 1 deletion docs/gnu_linux.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ sudo mount -o remount,user_xattr /dev/sda3

[//]: # (XXX_PYTHON)

Nuxeo Drive is officially supported on **Python 3.9.1+**.
Nuxeo Drive is officially supported on **Python 3.12.3+**.

## Installation

Expand Down
2 changes: 1 addition & 1 deletion docs/support.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ It may evolve quickly without notification as we are following the Python develo

[//]: # (XXX_PYTHON)

As of now, we are using the __Python 3.9.5__.
As of now, we are using the __Python 3.12.3__.

History:

Expand Down
2 changes: 1 addition & 1 deletion nxdrive/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ def get_certificate_details(
Note: This function uses a undocumented method of the _ssl module.
It is continuously tested in our CI to ensure it still
available after any Python upgrade.
Certified working as of Python 3.9.5.
Certified working as of Python 3.12.3.
"""

import ssl
Expand Down
2 changes: 1 addition & 1 deletion tools/posix/deploy_ci_agent.sh
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ check_upgrade() {
check_vars() {
# Check required variables
if [ "${PYTHON_DRIVE_VERSION:-unset}" = "unset" ]; then
export PYTHON_DRIVE_VERSION="3.9.5" # XXX_PYTHON
export PYTHON_DRIVE_VERSION="3.12.3" # XXX_PYTHON
fi
if [ "${WORKSPACE:-unset}" = "unset" ]; then
if [ "${GITHUB_WORKSPACE:-unset}" != "unset" ]; then
Expand Down
2 changes: 1 addition & 1 deletion tools/windows/deploy_ci_agent.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ function check_upgrade {
function check_vars {
# Check required variables
if (-Not ($Env:PYTHON_DRIVE_VERSION)) {
$Env:PYTHON_DRIVE_VERSION = '3.9.5' # XXX_PYTHON
$Env:PYTHON_DRIVE_VERSION = '3.12.3' # XXX_PYTHON
}
if (-Not ($Env:WORKSPACE)) {
if ($Env:GITHUB_WORKSPACE) {
Expand Down
Loading