NXDRIVE-2844: Nuxeo Drive transfer failed after removing hardware (Sourcery refactored)

[sourcery-ai]

Pull Request #4046 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the wip-NXDRIVE-2844-Nuxeo-Drive-transfer-failed-after-removing-hardware branch, then run:

git fetch origin sourcery/wip-NXDRIVE-2844-Nuxeo-Drive-transfer-failed-after-removing-hardware
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[codecov]

Codecov Report

Patch coverage: 11.11% and project coverage change: -0.02% ⚠️

Comparison is base (92bc486) 47.24% compared to head (1f01d64) 47.23%.

Additional details and impacted files

@@                                           Coverage Diff                                            @@
##           wip-NXDRIVE-2844-Nuxeo-Drive-transfer-failed-after-removing-hardware    #4047      +/-   ##
========================================================================================================
- Coverage                                                                 47.24%   47.23%   -0.02%     
========================================================================================================
  Files                                                                        93       93              
  Lines                                                                     15645    15640       -5     
========================================================================================================
- Hits                                                                       7392     7388       -4     
+ Misses                                                                     8253     8252       -1     

Flag	Coverage Δ
functional	37.80% <11.11%> (-0.02%)	⬇️
integration	1.98% <0.00%> (+<0.01%)	⬆️
unit	35.73% <0.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
nxdrive/engine/processor.py	10.94% <11.11%> (-0.17%)	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sourcery-ai]

Function Processor._get_next_doc_pair refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)

[sourcery-ai]

Function Processor._execute refactored with the following changes:

• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)
• Swap if/else branches (swap-if-else-branches)
• Remove unnecessary else after guard condition (remove-unnecessary-else)

[sourcery-ai]

Function Processor._synchronize_direct_transfer refactored with the following changes:

• Replace if statement with if expression (assign-if-exp)

This removes the following comments ( why? ):

# The path retrieved from the database will have its starting slash trimmed, restore it

[sourcery-ai]

Function Processor._direct_transfer_end refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)

This removes the following comments ( why? ):

# Update session then handle the status

[sourcery-ai]

Function Processor._synchronize_if_not_remotely_dirty refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)