Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.9.3 #508

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
99bb368
doc's fix for uuid description (#437)
Gevorg-Khachatryan-97 Sep 23, 2024
48aab1a
update requirements (#499)
george-ghawali Sep 23, 2024
de49880
Added fix for module.fail_json, now it takes 2 Arguments (#498)
abhinavbansal29 Sep 23, 2024
b2f4c72
Adding ansible lint fixes for examples directory
george-ghawali Sep 24, 2024
19ff5eb
plugins and tests spell checked (#491)
konstruktoid Sep 29, 2024
ab9f1e9
doc: format markdown table (#492)
DemoYeti Sep 29, 2024
120ba18
add msg if API response can't be converted (#486)
konstruktoid Sep 30, 2024
3b13ae2
issue#481 fix invalid dn check for OU vs group or user (#482)
stahnjones Oct 1, 2024
854442f
Adding fix for updating empty CD ROM with clone image attribute (#505)
george-ghawali Oct 1, 2024
2b203c6
Merge branch 'release/1.9.3' into imprv/lint-fixes-examples
george-ghawali Oct 2, 2024
5360e2b
Remove ansible lint from workflows
george-ghawali Oct 2, 2024
1e75a61
Adding imprv where user can group VMs by project name
george-ghawali Oct 7, 2024
9dbfa5b
Resolving comments
george-ghawali Oct 7, 2024
c8b089b
Revert "Adding imprv where user can group VMs by project name"
george-ghawali Oct 7, 2024
a8ab0f3
Merge pull request #513 from nutanix/feat/revert-issue#500
george-ghawali Oct 7, 2024
3a62c53
Adding lint checks in pull requests pipelines
george-ghawali Oct 7, 2024
dbfd5e1
resolving comments
george-ghawali Oct 8, 2024
2457d0f
Merge pull request #514 from nutanix/imprv/issue#458
george-ghawali Oct 8, 2024
db7120a
Merge pull request #502 from nutanix/imprv/lint-fixes-examples
george-ghawali Oct 8, 2024
48ba881
Merge remote-tracking branch 'origin/release/1.9.3' into imprv/issue#500
george-ghawali Oct 8, 2024
9459ce3
Merge pull request #511 from nutanix/imprv/issue#500
george-ghawali Oct 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/ansible-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
name: ansible-lint
on:
push:
branches:
- main
pull_request:
branches:
- main

jobs:
build:
name: Ansible Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Python 3.x (latest)
uses: actions/setup-python@v2
with:
python-version: 3.x
- name: Run ansible-lint
uses: ansible/ansible-lint@main
194 changes: 97 additions & 97 deletions README.md

Large diffs are not rendered by default.

9 changes: 3 additions & 6 deletions examples/acp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
- name: ACP playbook
hosts: localhost
gather_facts: false
collections:
- nutanix.ncp
module_defaults:
group/nutanix.ncp.ntnx:
nutanix_host: <pc_ip>
Expand All @@ -12,10 +10,9 @@
validate_certs: false

tasks:

- name: Create ACP with all specfactions
ntnx_acps:
validate_certs: False
nutanix.ncp.ntnx_acps:
validate_certs: false
state: present
nutanix_host: "{{ IP }}"
nutanix_username: "{{ username }}"
Expand All @@ -41,7 +38,7 @@
collection: ALL

- name: Delete ACP
ntnx_acps:
nutanix.ncp.ntnx_acps:
state: absent
acp_uuid: "{{ acp_uuid }}"
register: result
11 changes: 4 additions & 7 deletions examples/acp_info.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
- name: ACP_Info playbook
hosts: localhost
gather_facts: false
collections:
- nutanix.ncp
module_defaults:
group/nutanix.ncp.ntnx:
nutanix_host: <pc_ip>
Expand All @@ -12,20 +10,19 @@
validate_certs: false

tasks:

- name: List ACPs using ascending, sorting and name filter
ntnx_floating_ips_info:
nutanix.ncp.ntnx_acps_info:
filter:
name: "{{ acp_name }}"
kind: access_control_policy
sort_order: "ASCENDING"
sort_attribute: "name"
register: result
ignore_errors: True
ignore_errors: true

- name: List ACPs using length and offset
ntnx_floating_ips_info:
nutanix.ncp.ntnx_acps_info:
length: 3
offset: 0
register: result
ignore_errors: True
ignore_errors: true
14 changes: 6 additions & 8 deletions examples/address_groups_crud.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
- name: Address group crud playbook. Here we will create, update, read and delete the address group.
hosts: localhost
gather_facts: false
collections:
- nutanix.ncp
module_defaults:
group/nutanix.ncp.ntnx:
nutanix_host: <pc_ip>
Expand All @@ -11,7 +9,7 @@
validate_certs: false
tasks:
- name: Create a address group
ntnx_address_groups:
nutanix.ncp.ntnx_address_groups:
state: present
name: test-ansible-group-1
desc: test-ansible-group-1-desc
Expand All @@ -22,8 +20,8 @@
network_prefix: 32
register: ag

- name: update address group
ntnx_address_groups:
- name: Update address group
nutanix.ncp.ntnx_address_groups:
state: present
address_group_uuid: "{{ ag.address_group_uuid }}"
name: test-ansible-group-1-updated
Expand All @@ -34,16 +32,16 @@
register: updated_ag

- name: Read the updated address group
ntnx_address_groups_info:
nutanix.ncp.ntnx_address_groups_info:
address_group_uuid: "{{ updated_ag.address_group_uuid }}"
register: ag_info

- name: Print the address group details
debug:
ansible.builtin.debug:
msg: "{{ ag_info }}"

- name: Delete the address group.
ntnx_address_groups:
nutanix.ncp.ntnx_address_groups:
state: absent
address_group_uuid: "{{ updated_ag.address_group_uuid }}"
register: op
24 changes: 11 additions & 13 deletions examples/category_crud.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
- name: categories crud playbook. Here we will create, update, read and delete the category key values.
- name: Categories crud playbook. Here we will create, update, read and delete the category key values.
hosts: localhost
gather_facts: false
collections:
- nutanix.ncp
module_defaults:
group/nutanix.ncp.ntnx:
nutanix_host: <pc-ip>
Expand All @@ -11,22 +9,22 @@
validate_certs: false
tasks:
- name: Create only category key with description
ntnx_categories:
nutanix.ncp.ntnx_categories:
state: "present"
name: "test-cat-1"
desc: "test-cat-1-desc"
register: cat1

- name: Add category values to test-cat-1
ntnx_categories:
nutanix.ncp.ntnx_categories:
state: "present"
name: "test-cat-1"
values:
- "val1"
- "val2"

- name: Create category key with values
ntnx_categories:
nutanix.ncp.ntnx_categories:
state: "present"
name: "test-cat-2"
desc: "test-cat-2-desc"
Expand All @@ -36,33 +34,33 @@
register: cat2

- name: Add more category values to test-cat-2
ntnx_categories:
nutanix.ncp.ntnx_categories:
state: "present"
name: "test-cat-2"
values:
- "val5"
- "val6"

- name: Get categories info
ntnx_categories_info:
nutanix.ncp.ntnx_categories_info:
name: "test-cat-1"
register: cat1_info

- name: Delete val1 category value from test-cat-1
ntnx_categories:
nutanix.ncp.ntnx_categories:
state: absent
name: "test-cat-1"
values:
- val1

- name: delete all category values from test-cat-1
ntnx_categories:
- name: Delete all category values from test-cat-1
nutanix.ncp.ntnx_categories:
state: absent
name: "test-cat-1"
remove_values: true

- name: delete category key test-cat-2 including its all values
ntnx_categories:
- name: Delete category key test-cat-2 including its all values
nutanix.ncp.ntnx_categories:
state: absent
name: "test-cat-2"
remove_values: true
44 changes: 21 additions & 23 deletions examples/clusters_info.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
- name: Clusters_Info playbook
hosts: localhost
gather_facts: false
collections:
- nutanix.ncp
module_defaults:
group/nutanix.ncp.ntnx:
nutanix_host: <pc_ip>
Expand All @@ -12,27 +10,27 @@
validate_certs: false

tasks:
- name: test getting all clusters
ntnx_clusters_info:
register: clusters
- name: Test getting all clusters
nutanix.ncp.ntnx_clusters_info:
register: clusters

- name: test getting particular cluster using uuid
ntnx_clusters_info:
cluster_uuid: '{{ clusters.response.entities[0].metadata.uuid }}'
register: result
- name: Test getting particular cluster using uuid
nutanix.ncp.ntnx_clusters_info:
cluster_uuid: "{{ clusters.response.entities[0].metadata.uuid }}"
register: result

- name: List clusters using length, offset, sort order and priority sort attribute
ntnx_clusters_info:
length: 2
offset: 0
sort_order: "ASCENDING"
sort_attribute: "name"
register: result
- name: List clusters using length, offset, sort order and priority sort attribute
nutanix.ncp.ntnx_clusters_info:
length: 2
offset: 0
sort_order: "ASCENDING"
sort_attribute: "name"
register: result

- name: List clusters using filter and custom_filter
ntnx_clusters_info:
filter:
name: <name>
custom_filter:
external_ip: <external_ip>
register: result
- name: List clusters using filter and custom_filter
nutanix.ncp.ntnx_clusters_info:
filter:
name: <name>
custom_filter:
external_ip: <external_ip>
register: result
Loading
Loading