Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin requirements versions and update download logic #41

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Pin requirements versions and update download logic #41

merged 2 commits into from
Jun 17, 2024

Conversation

saileshd1402
Copy link
Contributor

@saileshd1402 saileshd1402 commented Jun 13, 2024 •
edited
Loading

Pin "setuptools" to 69.5.1 in llm/requirements.txt to avoid the following error:

2024-06-11T04:43:55,927 [INFO ] W-9000-tinyllama_fe8a4ea1ffedaf415f4da2f062534de366a451e6-stdout MODEL_LOG - ModuleNotFoundError: No module named 'ts.torch_handler.handler'

Related PR: nutanix/nai-llm-k8s#54

Changes:

  1. Pin requirements versions
  2. Updated hf_download logic to accomodate .safetensors files
  3. Removed "check_if_model_files_exist" check

@gavrissh
Copy link
Collaborator

Thanks for the fix

@saileshd1402
Squashed commit of the following:
8fce01a 
commit b07388b
Author: [email protected] <[email protected]>
Date:   Mon Jun 17 10:42:42 2024 +0000

    change hf_hub version

commit ecc299e
Author: [email protected] <[email protected]>
Date:   Mon Jun 17 10:13:51 2024 +0000

    fix hf hub errors
@saileshd1402 saileshd1402 changed the title pin setuptools in requirements.txt Pin requirements versions and update download logic Jun 17, 2024
gavrissh
gavrissh reviewed Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@gavrissh gavrissh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johnugeorge johnugeorge merged commit e2ecb4d into nutanix:main Jun 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavrissh gavrissh gavrissh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saileshd1402 @gavrissh @johnugeorge