Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get CI testing working again and prevent future bit-rot #165

Merged
merged 14 commits into from
Sep 28, 2024
Merged

Get CI testing working again and prevent future bit-rot #165

merged 14 commits into from
Sep 28, 2024

Conversation

anholt
Copy link
Contributor

@anholt anholt commented Sep 24, 2024

Description

When I started hacking on kerla, the CI was failing due to unpinned crates being installed. Rather than check what version CI used to be running, I bumped the rust nightly we use until it built the deps again, fixed the clippies, and then pinned those crates.

Pre-Submission Checklist

When you submit a PR, please make sure your PR satisfies the following checklist:

  • I assert this contribution was authored by me.
  • I license this contribution under the license of this project.
  • The PR title describes your changes briefly and uses the present tense, without a trailing full stop.
  • The PR description describes the reason why we need the change.
  • This is an isolated change. No multiple changes and no unrelated changes are included.
  • Fixed all cargo clippy warnings.
  • Applied rustfmt.

anholt added 14 commits September 23, 2024 17:10
@anholt
Apply cargo fmt.
29f0767
@anholt
Drop use of unaligned_references feature and clean up warnings.
7ca0c81
@anholt
Drop "packed" annotation from Process.
bd99665 
It doesn't look like it's required, and it's causing unaligned
references that newer rust hates.
@anholt
Fix pasteos for syscall/interrupt stack alloc errors.
0546919
@anholt
Give the KERNEL/USER bit fields actual bit field values.
faf6c37 
Future rust clippy errors about them doing "& 0" operations.  We can
decide if they're useful flags later if we actually want.
@anholt
Add a note about the apparently-dead kernel_stack.
a19cd67 
Quiets clippy warnings in the strict-lint target.
@anholt
Drop slice_internals feature -- causes a warning, doesn't seem necess…
769dff0 
…ary.
@anholt
Drop redundant pub(self) annotations.
40f7a7d 
Fixes future clippy lints.
@anholt
Clean up some derefs that the compiler performs anyway.
1818798 
Fixes future clippy lints.
@anholt
Drop redundant casts.
3b65db8 
Fixes future clippy lints.
@anholt
Suppress or work around the new clippy 0-bitmask lints.
252d82a
@anholt
Bump the nightly toolchain a bit so CI can have some hope again.
328e7d7 
Fixes the new clippy complaints in the process.
@anholt
Pin the cargo-binutils and rustfilt versions in CI so it's more repro…
1c67f92 
…ducible.
@anholt
Work around testing image build failure.
86c2899 
The RUN was throwing errors with current docker, but we can easily
enough just make it another ADD.
nuta
nuta reviewed Sep 25, 2024
View reviewed changes
Copy link
Owner

@nuta nuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks it's awesome! Left a quick question.

.github/workflows/ci.yml Show resolved Hide resolved
nuta
nuta approved these changes Sep 28, 2024
View reviewed changes
Copy link
Owner

@nuta nuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@nuta nuta merged commit 9816b67 into nuta:main Sep 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuta nuta nuta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anholt @nuta