-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AY1920S1-CS2113T-F11-1] SpongeBob #41
Open
Tejasvas123
wants to merge
149
commits into
nusCS2113-AY1920S1:master
Choose a base branch
from
AY1920S1-CS2113T-F11-1:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[AY1920S1-CS2113T-F11-1] SpongeBob #41
Tejasvas123
wants to merge
149
commits into
nusCS2113-AY1920S1:master
from
AY1920S1-CS2113T-F11-1:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add toolVersion block in to Gradle code sample to prevent errors.
Change file mode on `gradle` to be executable (#9)
Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.
Add configuration for console applications
Required for automating build process
Zhubo225
approved these changes
Nov 7, 2019
* change error message for zone (bugfix) * make file parsing more comprehensive
* change error message for zone (bugfix) * make file parsing more comprehensive * add basic j-unit testing for models * refactor storage in order to make undo-redo easy
* Stats function included * Update Stats * Update Stats.java
* Stats function included * Update Stats * Update Stats.java * Merge branch 'master' of https://github.com/AY1920S1-CS2113T-F11-1/main * Changed StatsCommand * Included student info while exporting * Changed csv location
* code cleanup * fix checkstyle errors
* modify javadoc for parser and storage * modify javadoc for models * add javadoc for logic.commands * add sample data * checkstyle
Zhubo225
approved these changes
Nov 10, 2019
* Stats function included * Update Stats * Update Stats.java * Merge branch 'master' of https://github.com/AY1920S1-CS2113T-F11-1/main * Changed StatsCommand * Included student info while exporting * Changed csv location * Included Selection of Tag for Exporting CSV * merge conflict * pass checkstyle * clean code * Fixed Minor Issues of Export Selection of CSV, adjusted export selection of parser files. Fixed Minor Issues of Export Selection of CSV, adjusted export selection of parser files. * added in case check * included start and end date for both methods of exporting csv file. * fixed checkstyle * minor fixes to parser export * Modified input for Export CSV selection * Minor Adjustments * Minor changes to code
* Dev Guide Changes * week 11 * test v1.5 * Final-features:RemindersFindSort * FindSortReminders * fixed errors from last pr * changes to reminders command regarding exceptions
* add clear all command * add java-doc * resolve checkstyle errors
Zhubo225
approved these changes
Nov 11, 2019
* Dev Guide Changes * week 11 * test v1.5 * Final-features:RemindersFindSort * FindSortReminders * fixed errors from last pr * changes to reminders command regarding exceptions * changes to sort: integer sorting and exception for empty list. Updated UG
* Final update for SELECT/UNDO/REDO/HISTORY/HELP commands and Ui * Final update for SELECT/UNDO/REDO/HISTORY/HELP commands and Ui * Final update for SELECT/UNDO/REDO/HISTORY/HELP commands and Ui
* Stats function included * Update Stats * Update Stats.java * Merge branch 'master' of https://github.com/AY1920S1-CS2113T-F11-1/main * Changed StatsCommand * Included student info while exporting * Changed csv location * Included Selection of Tag for Exporting CSV * merge conflict * pass checkstyle * clean code * Fixed Minor Issues of Export Selection of CSV, adjusted export selection of parser files. Fixed Minor Issues of Export Selection of CSV, adjusted export selection of parser files. * added in case check * included start and end date for both methods of exporting csv file. * fixed checkstyle * minor fixes to parser export * Modified input for Export CSV selection * Minor Adjustments * Minor changes to code * Updated UG * Edited UG DG Added in Appendix E: Instructions for Manual Testing * Added in Export and Stats Syntax for UI * edited ug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Zhubo225
@KevinAlvarez7
@swang1997