[AY1920S1-CS2113T-F09-4] Ducats #29

rohan-av · 2019-09-11T07:13:51Z

@jwyf
@SalonetheGreat
@rishi12438
@Samuel787

rishi12438 · 2019-10-02T10:32:56Z

looks good

[CS2113T-T14-2]-CEGLincoln-B-DoWithinPeriodTasks

langyanbin0314

Should use enum instead of numbers and strings.
Should remove necessary classes and comments.
There are a lot of magic strings in code, should define as variables.

langyanbin0314 · 2019-10-22T13:39:21Z

src/main/java/duke/ConflictChecker.java

+        for (Task temp : taskTempList) {
+            LocalDateTime startDateCheck = checkTask.getStartDate();
+            LocalDateTime endDateCheck = checkTask.getEndDate();
+            if (temp.getType().equals("E")) {


no magic string/character

langyanbin0314 · 2019-10-22T13:40:16Z

src/main/java/duke/DatePattern.java

+    public ParseTime.TimePatternType get_type() {
+        return type; 
+    }
+
+    public String get_pattern() {
+        return pattern; 
+    }


use camel case

langyanbin0314 · 2019-10-22T13:41:04Z

src/main/java/duke/Duke.java

+import java.util.Timer;
+import java.util.TimerTask;
+
+public class Duke {


should be your own product

langyanbin0314 · 2019-10-22T13:41:24Z

src/main/java/duke/Duke.java

+        //        try {
+        //            storage.loadList(tasks);
+        //        } catch (DukeException e) {
+        //            System.out.println(ui.showError(e));
+        //            tasks = new TaskList();
+        //        }


langyanbin0314 · 2019-10-22T13:41:51Z

src/main/java/duke/Duke.java

+        boolean isExit = false;
+        TimerTask repeatedTask = new TimerTask() {
+            public void run() {
+                Command c = new RemindCommand();


should give meaningful variable name

langyanbin0314 · 2019-10-22T13:44:55Z

src/main/java/duke/DukeException.java

+        if (input.trim().equals("todo") || input.trim().equals("event")
+                || input.trim().equals("deadline") || input.trim().equals("doafter")
+                || input.trim().equals("new") || input.trim().equals("view")
+                || input.trim().equals("addbar")) {
+
+            message = "OOPS!!! The description of "
+                    + word
+                    + input.trim()
+                    + " task cannot be empty.";
+        } else if (!type.equals("other")) {
+            switch (type) {
+            case "todo": {
+                message = "OOPS!!! I'm sorry, but I don't know what that means :-(";
+                break;
+            }
+            case "event": {
+                if (!input.contains("/at")) {
+                    message = "OOPS!!! duke.tasks.Event is missing a location.";
+                }
+                break;
+            }
+            case "deadline": {
+                if (!input.contains("/by")) {
+                    message = "OOPS!!! duke.tasks.Deadline is missing a deadline.";
+                }
+                break;
+            }
+            case "doafter": {
+                if (!input.contains("/after")) {
+                    message = "OOPS!!! duke.tasks.DoAfter is missing a task it is supposed to be done after.";
+                } else {
+                    message = "Please enter the task number of the task that the DoAfter should be after.";
+                }
+                break;
+            }
+            case "new": {
+                message = "OOPS!!! duke.components.Song cannot be created due to invalid input format.";
+                break;
+            }
+            case "view": {
+                message = "OOPS!!! I don't know that song. Please be more specific in the song name.";
+                break;
+            }
+            case "addbar": {
+                message = "OOPS!!! New bar cannot be added due to invalid input.";
+                break;
+            }
+            case "io": {
+                message = "OOPS!!! An IO exception has occurred.";
+                break;
+            }
+            case "no_index": {
+                message = "The index does not exist!";
+                break;
+            }
+            case "empty": {
+                message = "List is empty! Please enter a valid command.";
+                break;
+            }
+            case "conflict": {
+                message = "There is a conflict between this event and another event!";
+                break;
+            }
+            case "index": {
+                message = "Invalid index! Please try again.";
+                break;
+            }
+            case "between": {
+                message = "Invalid input for a between task. "
+                        + "Please follow this format: between <task_description> /between <start> and <end>";
+                break;
+            }
+            case "recur": {
+                message = "Invalid input for a recurring task. Please follow this format:"
+                        + " recur <frequency> <description> /on <date> /at <time>\n";
+                message += "<frequency> could only be one of: daily, weekly, monthly or yearly\n";
+                message += "<date> has to follow the specific format of: dd/mm/yy\n";
+                message += "/at <time> is optional.";
+                break;
+            }
+            case "group": {
+                message = "OOPS!!! These groups cannot be grouped due to invalid input.";
+                break;
+            }
+            case "copy": {
+                message = "OOPS!!! Invalid input for copy command.";
+                break;
+            }
+            default: {
+                message = "OOPS!!! I'm sorry, but I don't know what that means :-(";
+            }
+            }
+        } else {
+            message = "OOPS!!! I'm sorry, but I don't know what that means :-(";
+        }
+        return Ui.wrap(message);
+        // wrap is called from Ui in order to standardize the formatting of the output
+    }


should use enum

langyanbin0314 · 2019-10-22T13:45:46Z

src/main/java/duke/Parser.java

+     * @throws DukeException in the case of parsing errors
+     */
+    static Command parse(String message) throws DukeException {
+        switch (message.split(" ")[0]) {


langyanbin0314 · 2019-10-22T13:50:21Z

src/main/java/duke/Ui.java

+                             Integer pasteStartNum,
+                             int mode) {
+        String result;
+        if (mode == 0) {


langyanbin0314 · 2019-10-22T14:00:31Z

src/main/java/duke/commands/Tutorial.java

@@ -0,0 +1,25 @@
+package duke.commands;


remove necessary class

langyanbin0314 · 2019-10-22T14:04:57Z

src/main/java/duke/tasks/Task.java

@@ -0,0 +1,67 @@
+package duke.tasks;


remove duke classes

Update to fix parsing error

Fix JAR storage issue

Refactor code to have better Command syntax consistency

fixed bugs

fixed bug for autosuggest

PR W12 Tuesday 1011

Create new exception to prevent same song names

PR W12 Tuesday 1220

* Finish PPP entirely and Finish Appendix E for DG * Update to v1.4

PR due time

* 'master' of https://github.com/SalonetheGreat/main: Update to v1.4 (#251) Update UG and DG (#250) updated ug 4 updated ug 4

ppp

* 'master' of https://github.com/SalonetheGreat/main: ppp done

…Commands

* Add ascii song for UG * Fix a bug in UG

Add ascii song for UG (#253)

Fix image issues with adocs

PR W13 Tue 0023

* Finish PPP entirely and Finish Appendix E for DG * Update to v1.4 * Final update

Add overlay_group_group_1_2.png

* 'master' of https://github.com/SalonetheGreat/main: Update UG (#255)

* 'master' of https://github.com/SalonetheGreat/main:

Add Command Summary

This closes nusCS2113-AY1920S1#29.

x3chillax referenced this pull request in x3chillax/main Oct 16, 2019

Merge pull request AY1920S1-CS2113-T14-2#29 from CEGLincoln/mybranch

d0e9666

[CS2113T-T14-2]-CEGLincoln-B-DoWithinPeriodTasks

nus-se-pr-bot added team.4 tutor.langyanbin0314 tutorial.CS2113T-F09 labels Oct 17, 2019

langyanbin0314 reviewed Oct 22, 2019

View reviewed changes

jwyf and others added 24 commits November 1, 2019 00:50

Merge pull request #148 from rohan-av/master

d4c0648

Update to fix parsing error

Refactor code to have consistent Command syntax

55b156d

Fix JAR storage issue

13dbc12

Refactor code for Command input consistency

a0f5617

Merge pull request #150 from rohan-av/master

2f8985d

Fix JAR storage issue

Merge branch 'master' into SongCommands

19c0ccd

Merge pull request #151 from jwyf/SongCommands

c03dbb1

Refactor code to have better Command syntax consistency

fixed bugs

57fe813

fixed for check style

c0ccb1b

Unit testing added

54e829d

Merge branch 'master' of https://github.com/AY1920S1-CS2113T-F09-4/main

3182d16

Merge pull request #199 from rishi12438/master

e9f9a2b

fixed bugs

Merge branch 'master' of https://github.com/AY1920S1-CS2113T-F09-4/main

d8213da

Ascii song now wraps after every 8th bar

1eb0a3d

fixed bug in autosuggest

86c3aea

fixed according to checkstyle

f0a2032

Merge pull request #201 from rishi12438/master

67d1c83

fixed bug for autosuggest

Create new exception to prevent same song names

4149ea5

Update to fit checkstyle requirements

ab137fe

Merge pull request #9 from AY1920S1-CS2113T-F09-4/master

f30d65e

PR W12 Tuesday 1011

Merge pull request #202 from jwyf/SongCommands

d0dea71

Create new exception to prevent same song names

Merge pull request #10 from AY1920S1-CS2113T-F09-4/master

e9d32ef

PR W12 Tuesday 1220

added junit testing

4a288c3

Merge branch 'master' of https://github.com/AY1920S1-CS2113T-F09-4/main

cc9a88e

rishi12438 and others added 29 commits November 11, 2019 23:52

Merge branch 'master' of https://github.com/AY1920S1-CS2113T-F09-4/main

4de036e

Update to v1.4 (#251)

4d87289

* Finish PPP entirely and Finish Appendix E for DG * Update to v1.4

Merge branch 'master' into master

b8a01c3

Merge pull request #17 from AY1920S1-CS2113T-F09-4/master

070e804

PR due time

Add ascii song for UG

98adc86

Merge branch 'master' of https://github.com/SalonetheGreat/main

2723153

* 'master' of https://github.com/SalonetheGreat/main: Update to v1.4 (#251) Update UG and DG (#250) updated ug 4 updated ug 4

Merge pull request #252 from rishi12438/master

10af278

ppp

Merge branch 'master' into master

bf582e0

Fix a bug in UG

5f3f3cc

Merge branch 'master' of https://github.com/SalonetheGreat/main

ec23947

* 'master' of https://github.com/SalonetheGreat/main: ppp done

Fixed image issues with UG and DG

1bdc589

Fix image issues with adocs

a9a42cb

Merge branch 'SongCommands' of https://github.com/jwyf/main into Song…

8879870

…Commands

Add ascii song for UG (#253)

f4e6146

* Add ascii song for UG * Fix a bug in UG

Merge pull request #18 from AY1920S1-CS2113T-F09-4/master

3fae1c6

Add ascii song for UG (#253)

Merge branch 'master' into SongCommands

98ffccb

Merge pull request #254 from jwyf/SongCommands

5680f1e

Fix image issues with adocs

Merge pull request #19 from AY1920S1-CS2113T-F09-4/master

b3477cd

PR W13 Tue 0023

Update UG (#255)

3dae4bc

* Finish PPP entirely and Finish Appendix E for DG * Update to v1.4 * Final update

Add overlay_group_group_1_2.png

eed38f0

Merge branch 'master' into master

49ad9ef

Merge pull request #256 from SalonetheGreat/master

f47deb4

Add overlay_group_group_1_2.png

Add Command Summary

8a18dac

Merge branch 'master' of https://github.com/SalonetheGreat/main

937c17a

* 'master' of https://github.com/SalonetheGreat/main: Update UG (#255)

Merge branch 'master' into master

f2a4fc3

Remove clear and close from CommandSyntaxMessage

1f0e733

Minor changes to UG

b998256

Merge branch 'master' of https://github.com/SalonetheGreat/main

4939c84

* 'master' of https://github.com/SalonetheGreat/main:

Merge pull request #257 from SalonetheGreat/master

9c906bf

Add Command Summary

nishanthelango pushed a commit to nishanthelango/Duchess that referenced this pull request Nov 23, 2021

tidy up packages (nusCS2113-AY1920S1#32)

55543ca

This closes nusCS2113-AY1920S1#29.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AY1920S1-CS2113T-F09-4] Ducats #29

[AY1920S1-CS2113T-F09-4] Ducats #29

rohan-av commented Sep 11, 2019

rishi12438 commented Oct 2, 2019

langyanbin0314 left a comment

langyanbin0314 Oct 22, 2019

langyanbin0314 Oct 22, 2019

langyanbin0314 Oct 22, 2019

langyanbin0314 Oct 22, 2019

langyanbin0314 Oct 22, 2019

langyanbin0314 Oct 22, 2019

langyanbin0314 Oct 22, 2019

langyanbin0314 Oct 22, 2019

langyanbin0314 Oct 22, 2019

langyanbin0314 Oct 22, 2019

[AY1920S1-CS2113T-F09-4] Ducats #29

Are you sure you want to change the base?

[AY1920S1-CS2113T-F09-4] Ducats #29

Conversation

rohan-av commented Sep 11, 2019

rishi12438 commented Oct 2, 2019

langyanbin0314 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment