[W7][T11-2]Matthias Lum #47
Conversation
added a column in the address book for appointment date with the doctor
There was a problem hiding this comment.
Hi Matthias,
Excellent effort. You have updated the documentation, furnished your enhancement and considered adding tests.
One thing to note: your default example value in the Appointment class is 30November. In your test case input, it is also 30November. You could have supplied a different input, to show that your function is able to take in other appointment date values.
| @@ -60,6 +62,8 @@ public ReadOnlyPerson getPerson() { | |||
| public CommandResult execute() { | |||
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| return appointmentDate; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| @@ -30,6 +31,7 @@ default boolean isSameStateAs(ReadOnlyPerson other) { | |||
| && other.getName().equals(this.getName()) // state checks here onwards | |||
| && other.getPhone().equals(this.getPhone()) | |||
| && other.getEmail().equals(this.getEmail()) | |||
| // && other.getAppointment().equals(this.getAppointment()) | |||
There was a problem hiding this comment.
Did you intend to comment this? Note that irrelevant comments added by you should be removed in your submissions.
|
Please close this PR after reviewing. |
Code edited to fit code style (Done)
Added an appointment class so that a user can input an appointment date with a doctor.