[W7][T11-2] Teo Xuan Wei #46
Conversation
There was a problem hiding this comment.
Hi Xuan Wei,
Good job with documentation update and code enhancement! See code inline comments for details for some specifics that you could improve on.
Also, you could supplement a Junit test of your enhancement.
You may close this PR after reviewing the comment.
| @@ -12,7 +12,7 @@ | |||
| * Main entry point to the application. | |||
| */ | |||
| public class Main extends Application implements Stoppable{ | |||
|
|
|||
| // test commit | |||
There was a problem hiding this comment.
Unnecessary comments should be removed.
| + "Example: " + COMMAND_WORD; | ||
| public static final String MESSAGE_SUCCESS = "Length of the address book is: "; | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| @@ -65,6 +65,10 @@ public void clear() { | |||
| allPersons.clear(); | |||
| } | |||
|
|
|||
| public int size() { | |||
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| @@ -113,6 +113,14 @@ public void clear() { | |||
| internalList.clear(); | |||
| } | |||
|
|
|||
| /** | |||
| * New method to get size of address book :D | |||
There was a problem hiding this comment.
Do note that your header comment should begin with a verb - e.g. Gets size of address book. This is the standard java coding convention that we are following.
EditTeam Function
New Command Length returns length of AB when queried by user.