[W7][T11-2]Li Guanlong #40
Conversation
|
This is a useful feature to prevent unwanted people from using the addressbook |
There was a problem hiding this comment.
Hi Guan Long,
Good work here in the login enhancement, updating the documentation and in providing the unit tests for the new enhancement. One thing to note: Header Comments are important, for code readability; you have missed that out in several of the new non-trivial methods.
See coding standard conventions for more information on what is required: https://nuscs2113-ay1819s2.github.io/website/coding-standards/java/intermediate.html
| public boolean getLoginStatus(){ | ||
| return loginStatus; | ||
| } | ||
|
|
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| public String checkLoginInfo(String userCommandText){ | ||
| String[] accountInfo = userCommandText.split(" "); | ||
| try { | ||
| if (accountInfo.length == 3 && accountInfo[0].equals("login")) { |
There was a problem hiding this comment.
You could apply some refactoring principles here. Multi-condition criteria could be extracted into booleans.
| private static final String Invalid_FORMAT = "Please input the correct login command: login username password"; | ||
| private Login login = new Login(); | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| assertEquals(login.getLoginStatus(), true); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| assertEquals(login.getLoginStatus(), false); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| final String input1 = "login guanlong 12345"; | ||
| final String input2 = "some_random_string"; | ||
| final String input3 = "login wrong_username wrong_password"; | ||
| assertEquals(login.checkLoginInfo(input1), SUCCESS); |
There was a problem hiding this comment.
Good job here, providing the positive and negative test cases.
Add Match Management
Added a new command: login, which is used for the user to login to the system before actually using the address book.