[W7][M11-2]Lee Wenhao Nicholas #39
Conversation
There was a problem hiding this comment.
This PR adds three command features: Signup, Login, and Logout to AB3. Accompanied is a hash function to hash the password (Good job).
I couldn't find any logic component associated to the PR, i.e., how is the login supposed to happen. (Did I miss it anywhere, kindly point out if thats the case)
Always add test cases whenever new features are added.
Your commit message format seems to be incorrect. Checkout the correct way to write commit messages.
Please close this PR after you read the comments.
| @@ -8,6 +8,8 @@ | |||
| import seedu.addressbook.ui.Gui; | |||
| import seedu.addressbook.ui.Stoppable; | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Minor comment - Avoid unnecessary whitespaces.
|
|
||
| Boolean isAuthenticated = false; | ||
|
|
||
| String testPassword = TEST + password; |
There was a problem hiding this comment.
Why is the TEST prefix used? If any particular use, mention it as a comment.
| isAuthenticated = true; | ||
| new CommandResult(MESSAGE_SUCCESS); | ||
| } else { | ||
| isAuthenticated = false; |
There was a problem hiding this comment.
Has the use of isAuthenticated implemented? I can't seem to find it.
| import java.security.NoSuchAlgorithmException; | ||
| import java.lang.String; | ||
|
|
||
| public class generateHash { |
There was a problem hiding this comment.
Add comments explaining the hashing process. An important part of SE is to aid future developers easily understand your code.
Team Management
Added , , feature
Updated User Guide