Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W7][T09-2]Jin Shibo #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[W7][T09-2]Jin Shibo #36

wants to merge 1 commit into from

Conversation

BrittonAlone
Copy link

Find persons by phone number feature added.

@nus-se-pr-bot nus-se-pr-bot requested a review from okkhoy March 3, 2019 10:47
RubaP
RubaP reviewed Mar 15, 2019
View reviewed changes
Copy link

@RubaP RubaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, It seems your 3kLoc enhancement is same as 2kLoc, hence I skip reviewing your code. Please do practice new enhancements in the future so that it will help you to practice SE principles as well as to gain new coding experience and feedback from the TA

@RubaP RubaP added the Reviewed label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubaP RubaP RubaP left review comments

@okkhoy okkhoy Awaiting requested review from okkhoy

Assignees

@RubaP RubaP

@sanjukta99 sanjukta99

Labels
Reviewed team.2 tutorial.T09
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrittonAlone @RubaP @nus-se-pr-bot @sanjukta99