Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W7][M11-3] Jemine Kan #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jemine1998
Copy link

No description provided.

Copy link

@devamanyu devamanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good PR (SE wise) for viewing private details of a person.

Try to add test cases for the feature.

Please close this PR after you read this comment.

* `find Betsy` +
`viewprivate 1` +
Views private details of the 1st person in the results of the `find` command.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on updating the user guide!

if (getAddress().isPrivate()) {
builder.append(getEmail()).append(" Address: ");
builder.append(detailIsPrivate).append(getAddress());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment - try to avoid unnecessary whitespaces!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants